Match unmatched backticks in compiler/ #108685
Conversation
|
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
A-query-system
|
Some changes occurred to the CTFE / Miri engine cc @rust-lang/miri Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
|
These two I don't know what to put: rust/compiler/rustc_hir_typeck/src/closure.rs Line 401 in 13471d3 |
est31
force-pushed
the
backticks_matchmaking
branch
from
779bb67
to
029ea8f
Compare
|
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
|
I think you should split out the library diff into a separate PR, based on this topic: https://rust-lang.zulipchat.com/#narrow/stream/131828-t-compiler/topic/Spelling.20is.20style.3F/near/328759605 |
|
@saethlin I think the concerns were mostly about PRs, many of which very low effort, that were extremely huge and offloaded the reviewing of the tool to the PR reviewer. They had questionable quality, and sometimes it was questionable if they were improvements at all. Here the improvement is tiny, but very clear. It should be easy to review it. I just saw an error message with an unmatched when working on #108682, ` and then wondered about other occurrences of the character in the code. This PR isn't just changing comments, it's also changing error messages of different kinds (both diagnostics and ICE messages). |
est31
force-pushed
the
backticks_matchmaking
branch
3 times, most recently
from
dc637b8
to
3d87a83
Compare
|
Okay reading through the thread of #58619, changes that only change rustc-internal comments aren't really liked, but if they are small in size, or easy to review they might still be accepted. Changes to public facing features/docs are still definitely wanted, even if cosmetic. I've split up this PR into multiple commits:
The commits have differing levels of controversialness. Please tell me which ones are not wanted and I should remove, and which ones I should put into different PRs. Thanks! |
est31
changed the title
est31
force-pushed
the
backticks_matchmaking
branch
from
3d87a83
to
00be991
Compare
|
Alright I have removed the commit that only changed the comments. I don't agree with the policy, and it might not actually be unwanted by that policy, but ultimately it's a choice I have to respect. Now all the changes should be non-controversial ones, I hope. |
|
You can make a separate PR with the compiler comments and add me or @WaffleLapkin as the reviewer, we're fine with reviewing it. |
est31
force-pushed
the
backticks_matchmaking
branch
from
00be991
to
c656a34
Compare
|
Alright, I have removed even the rustdoc changes from this PR (outside of the one commit about LiteralKind) and moved the two into #108694. Sorry for all the noise, I hope now it should be easy enough to review the patches. |
est31
force-pushed
the
backticks_matchmaking
branch
from
c656a34
to
c54f061
Compare
|
🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened. |
bors
added
S-waiting-on-bors
…rochenkov
Match unmatched backticks in compiler/
Found with GNU grep:
```
grep -rEn '^(([^`]*`){2})*[^`]*`[^`]*$' compiler/ | rg -v '\s*[//]?.{1,2}```'
```
…ts, r=Nilstrieb Match unmatched backticks in compiler/ comments r? `@Nilstrieb` as per [advice](rust-lang#108685 (comment))
…y, r=jyn514
Match unmatched backticks in library/
Found with GNU grep:
```
grep -rEn '^(([^`]*`){2})*[^`]*`[^`]*$' library/ | rg -v '\s*[//]?.{1,2}```'
```
split out from rust-lang#108685 as per advice.
…ts, r=Nilstrieb Match unmatched backticks in compiler/ comments r? ``@Nilstrieb`` as per [advice](rust-lang#108685 (comment))
…y, r=jyn514
Match unmatched backticks in library/
Found with GNU grep:
```
grep -rEn '^(([^`]*`){2})*[^`]*`[^`]*$' library/ | rg -v '\s*[//]?.{1,2}```'
```
split out from rust-lang#108685 as per advice.
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#107981 (new solver: implement canonicalization and region constraints) - rust-lang#108553 (Deny capturing late-bound non-lifetime param in anon const) - rust-lang#108599 (Remove legacy PM leftovers) - rust-lang#108667 (Fix another ICE in `point_at_expr_source_of_inferred_type`) - rust-lang#108674 (Clippy Fix array-size-threshold config deserialization error) - rust-lang#108685 (Match unmatched backticks in compiler/) - rust-lang#108694 (Match unmatched backticks in compiler/ comments) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Found with GNU grep: